Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19897 )
Change subject: IMPALA-10180: Add summary stats for client fetch wait time ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19897/1/tests/query_test/test_fetch.py File tests/query_test/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/19897/1/tests/query_test/test_fetch.py@134 PS1, Line 134: assert fetch_time_stats and len(fetch_time_stats.groups()) == 1 : : # Verify the number of samples : number_of_samples_re = re.search("Number of samples: (.*)", fetch_time_stats.group(1)) : assert number_of_samples_re and len(number_of_samples_re.groups()) == 1 : number_of_samples = int(number_of_samples_re.group(1).strip(')')) : # There are 5 fetches and the finalization sample for a total of 6. : assert number_of_samples == 6 : : # The 2.5 second sleep does count for an incomplete fetch, verify the max is higher. : max_time = re.search("Max: (.*) ;", fetch_time_stats.group(1)) : assert max_time and len(max_time.groups()) == 1 > optional: extract the time stats parsing logic to a function, e.g. in tests Added a new function in tests/parse_util.py to parse summary stats for times and switched this to use it. It duplicates some code from the bytes version, but it has different regexes and type conversions, so I kept it separate. -- To view, visit http://gerrit.cloudera.org:8080/19897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ca525285e03c7b51b04ac292f7b3531e6178218 Gerrit-Change-Number: 19897 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Thu, 18 May 2023 00:21:47 +0000 Gerrit-HasComments: Yes
