Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19722 )
Change subject: IMPALA-11253: Produce multiple Java docker images ...................................................................... Patch Set 3: (1 comment) I had a comment on https://issues.apache.org/jira/browse/IMPALA-12081 about changes in bin/start-impala-cluster.py. What do we want out of this? - We want https://jenkins.impala.io/view/Ubuntu%2020/job/ubuntu-20.04-dockerised-tests/ or https://jenkins.impala.io/view/all/job/rocky-8.5-dockerised-tests/ to be able to run with Java 11 - Currently, rocky-8.5-dockerised-tests sets IMPALA_DOCKER_USE_JAVA11=true. - The Java 11 images are independent of IMPALA_JDK_VERSION right now, so we produce Java 11 images even if we are building with Java 8. I think this is useful, because that seems like a configuration that can happen in user deployments. So, we need some way to tell the test job to run with Java 11 images or Java 8 images. http://gerrit.cloudera.org:8080/#/c/19722/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19722/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-11253: Produce multiple Java docker images Should we use IMPALA-12081 for this? -- To view, visit http://gerrit.cloudera.org:8080/19722 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b124267c607242bc2fd6c8cd6486293a938f50 Gerrit-Change-Number: 19722 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 18 May 2023 18:15:18 +0000 Gerrit-HasComments: Yes
