[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718 )
Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 ...................................................................... Patch Set 21: (1 comment) I am reviewing the changes specific to arm64 support, and I found this one difference in the llvm codegen that I can't understand. What is the purpose of the change in data types for arm64? And does this change have an impact on performance? http://gerrit.cloudera.org:8080/#/c/15718/21/be/src/codegen/codegen-anyval.cc File be/src/codegen/codegen-anyval.cc: http://gerrit.cloudera.org:8080/#/c/15718/21/be/src/codegen/codegen-anyval.cc@47 PS21, Line 47: return cg->i64_type(); Why arm64 uses i64 for all int types? What is the impact on arm64 performance due to this change? -- To view, visit http://gerrit.cloudera.org:8080/15718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f30ee84ea9bf5245da88154632bb69079103d11 Gerrit-Change-Number: 15718 Gerrit-PatchSet: 21 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 18 May 2023 18:29:27 +0000 Gerrit-HasComments: Yes
