Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19845 )
Change subject: IMPALA-11260: Add add-opens to JAVA_TOOL_OPTIONS on startup ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/19845/7/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19845/7/be/src/common/init.cc@97 PS7, Line 97: DEFINE_bool(jvm_automatic_add_opens, true > Nit: Some minor nitpicking about the name, maybe "jvm_automatic_add_opens"? Done -- To view, visit http://gerrit.cloudera.org:8080/19845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47a6533b2aa94593d9348e8e3606633f06a111e8 Gerrit-Change-Number: 19845 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 18 May 2023 21:12:04 +0000 Gerrit-HasComments: Yes
