Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19905 )
Change subject: WIP IMPALA-12150: Allow executors to register to two statestores ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19905/3/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: http://gerrit.cloudera.org:8080/#/c/19905/3/common/thrift/StatestoreService.thrift@26 PS3, Line 26: // Change message formats to support 2 statestores It seems the changes are backward compatible, i.e. just new optional fields added. Could you add commends on why we need a new version? http://gerrit.cloudera.org:8080/#/c/19905/3/common/thrift/StatestoreService.thrift@236 PS3, Line 236: V1 Do we need this to be V2 as well? -- To view, visit http://gerrit.cloudera.org:8080/19905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e2ff88a4a61279dea4be3432bb6460cbc33ef90 Gerrit-Change-Number: 19905 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 22 May 2023 12:17:16 +0000 Gerrit-HasComments: Yes
