Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19932 )
Change subject: IMPALA-12163: Fixes an issue when outputting RPC details where the start and end times could be longer than the call duration. Additionally, the end time of the exact same rpc call was different between stdout and the rpc details file. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19932/1/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/19932/1/shell/impala_client.py@1267 PS1, Line 1267: duration.microseconds another more serious issue was found: this should truncates the >1sec parts - the correct version would be duration.total_seconds() * 1000 (total_seconds is a float) -- To view, visit http://gerrit.cloudera.org:8080/19932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd9dec189d0f6fb8713fb1c7b2b6c663e492ef05 Gerrit-Change-Number: 19932 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 25 May 2023 13:31:29 +0000 Gerrit-HasComments: Yes
