Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19929 )
Change subject: IMPALA-12154: Trim recency list appropriate for LIRS ToUninitialize() ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19929/2/be/src/util/cache/lirs-cache-test.cc File be/src/util/cache/lirs-cache-test.cc: http://gerrit.cloudera.org:8080/#/c/19929/2/be/src/util/cache/lirs-cache-test.cc@288 PS2, Line 288: // Replace an protected key with a new value nit: an -> a http://gerrit.cloudera.org:8080/#/c/19929/2/be/src/util/cache/lirs-cache.cc File be/src/util/cache/lirs-cache.cc: http://gerrit.cloudera.org:8080/#/c/19929/2/be/src/util/cache/lirs-cache.cc@696 PS2, Line 696: DCHECK(&*recency_list_.begin() == e); nit: I think this could be &recency_list_.front(). -- To view, visit http://gerrit.cloudera.org:8080/19929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83298e0a042174a09f0144aa336b2eb2b28bfee8 Gerrit-Change-Number: 19929 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 25 May 2023 16:17:34 +0000 Gerrit-HasComments: Yes
