Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19930 )
Change subject: IMPALA-10971: Fix data cache metrics for instant evictions ...................................................................... IMPALA-10971: Fix data cache metrics for instant evictions When inserting an entry into the data cache, the Insert() can fail and instantly evict the new entry. This is currently only true for the LIRS cache eviction policy. When this happens, the cache metrics are not maintained properly. The instant eviction results in an unmatched decrement to the total bytes and num entries counters. This moves the increments to happen prior to the Insert() call, which fixes the instant eviction case. The behavior does not change noticeably for the successful Insert() case. Testing: - Added custom cluster test to verify this case Change-Id: I5db3eaca2f4459844e3270846d905f76265b6b3e Reviewed-on: http://gerrit.cloudera.org:8080/19930 Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/io/data-cache.cc M tests/custom_cluster/test_data_cache.py 2 files changed, 47 insertions(+), 6 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/19930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5db3eaca2f4459844e3270846d905f76265b6b3e Gerrit-Change-Number: 19930 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
