Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19838 )
Change subject: IMPALA-11534: Skip reloading file metadata for some ALTER_TABLE events ...................................................................... Patch Set 7: (4 comments) > Patch Set 7: > > Did you run the tests with the newest changes? They still use lower case > "external" so I think that there should be some failure. Verified and addressed. http://gerrit.cloudera.org:8080/#/c/19838/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/19838/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@376 PS7, Line 376: db > nit: Just confused, what does "db" stands for here? I thought it's "databas Will do. http://gerrit.cloudera.org:8080/#/c/19838/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3908 PS7, Line 3908: !isCustomTblPropsChanged(beforeTable, afterTable)) { > For supportability, we'd better split these to seperate if-clause and add l Ack http://gerrit.cloudera.org:8080/#/c/19838/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3926 PS7, Line 3926: !beforeCols.get(i).getType().equals(afterCols.get(i).getType())) > Need logs for these as well. Ack http://gerrit.cloudera.org:8080/#/c/19838/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3939 PS7, Line 3939: if (!Objects.equals(configBefore, configAfter)) return true; > Need logs for this as well. Ack -- To view, visit http://gerrit.cloudera.org:8080/19838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia66b96a7c4b7f50fbf46b2e02296cd29a47347b6 Gerrit-Change-Number: 19838 Gerrit-PatchSet: 7 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 07 Jun 2023 03:12:04 +0000 Gerrit-HasComments: Yes
