Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20010 )
Change subject: [WIP] IMPALA-11996: Scanner change for Iceberg metadtata querying ...................................................................... Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/20010/2/be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc File be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/20010/2/be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc@48 PS2, Line 48: metadata_table_name_ = new string(pnode.tnode_->iceberg_scan_metadata_node.metadata_table_name.c_str()); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/20010/2/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.h File be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.h: http://gerrit.cloudera.org:8080/#/c/20010/2/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.h@67 PS2, Line 67: inline static jclass fe_iceberg_table_cl_ = NULL; // org.apache.impala.catalog.FeIcebergTable line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/20010/2/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.h@102 PS2, Line 102: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20010/2/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc File be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc: http://gerrit.cloudera.org:8080/#/c/20010/2/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc@152 PS2, Line 152: jobject column_field = env->CallObjectMethod(columns, list_get_, slot_desc->col_pos()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20010/2/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc@258 PS2, Line 258: *reinterpret_cast<TimestampValue*>(slot) = TimestampValue::FromUnixTimeMicros(resu2lt, UTCPTR); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/20010/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20010/2/be/src/service/frontend.cc@110 PS2, Line 110: {"getCatalogTable", "([B)Lorg/apache/impala/catalog/FeTable;", &get_catalog_table_id_}, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20010/2/fe/src/main/java/org/apache/impala/planner/IcebergMetadataScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergMetadataScanNode.java: http://gerrit.cloudera.org:8080/#/c/20010/2/fe/src/main/java/org/apache/impala/planner/IcebergMetadataScanNode.java@40 PS2, Line 40: private final static Logger LOG = LoggerFactory.getLogger(IcebergMetadataScanNode.class); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20010/2/fe/src/main/java/org/apache/impala/planner/IcebergMetadataScanNode.java@45 PS2, Line 45: protected IcebergMetadataScanNode(PlanNodeId id, List<Expr> conjuncts, TableRef tblRef) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20010/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/20010/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@136 PS2, Line 136: Preconditions.checkState(iceTblRef.getTable() instanceof FeIcebergTable || iceTblRef.getTable() instanceof IcebergMetadataTable); line too long (133 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e943cecd77f5ef7af7cd07e2b596f2c5b4331e7 Gerrit-Change-Number: 20010 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 13 Jun 2023 09:44:54 +0000 Gerrit-HasComments: Yes
