Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20065 )
Change subject: IMPALA-12208: Avoid registering RPCs with ClientRequestState after Finalization ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20065/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20065/1/be/src/service/client-request-state.cc@189 PS1, Line 189: UnRegisterRemainingRPCs(); > Is it still useful to call this here? My assumption is that if !track_rpcs_ Probably better to leave it since memory would be leaked if anything still slipped through and the cost is minimal. -- To view, visit http://gerrit.cloudera.org:8080/20065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66415e5695c2ed65518efee2d9dbaaec224910e9 Gerrit-Change-Number: 20065 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Tue, 13 Jun 2023 12:00:18 +0000 Gerrit-HasComments: Yes
