Xiang Yang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19866
Change subject: IMPALA-12126: fix keywords and builtin function names conflict. ...................................................................... IMPALA-12126: fix keywords and builtin function names conflict. According to the rule: reservedWords = keywords + sql16ReservedWords - builtinFunctions - whitelist, the reserved words don't contain all the keywords because of the intersection of keywords and builtin function names. And a view will fail to load if it's defination contains these special words as identifier. This patch let reserved words become a superset of keyword by adjust the rule to: reservedWords = sql16ReservedWords - builtinFunctions - whitelist + keywords. Testing: - add a FE test to ToSqlTest. Change-Id: I818fbd5170576d40ee9d50798b42fe4532d7dbeb --- M fe/src/main/java/org/apache/impala/catalog/View.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java 3 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/19866/1 -- To view, visit http://gerrit.cloudera.org:8080/19866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I818fbd5170576d40ee9d50798b42fe4532d7dbeb Gerrit-Change-Number: 19866 Gerrit-PatchSet: 1 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
