Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19894 )
Change subject: IMPALA-12171: Optimize delimited output ...................................................................... Patch Set 9: Code-Review+1 (1 comment) LGTM. I can bump to +2 if no more comments. Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/19894/6/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/19894/6/shell/shell_output.py@105 PS6, Line 105: or result.count(delimiter) != expected_delimiters \ > I wouldn't complicate this part as I am considering actually implementing q Ack -- To view, visit http://gerrit.cloudera.org:8080/19894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I671c6f538c588f8ad4ef4067f7bc8a6b8a5220cb Gerrit-Change-Number: 19894 Gerrit-PatchSet: 9 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 15 Jun 2023 00:39:15 +0000 Gerrit-HasComments: Yes
