Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20095 )
Change subject: PROTOTYPE IMPALA-12220: Build wheels for ext-py shell dependencies ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/20095/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20095/4//COMMIT_MSG@10 PS4, Line 10: (cherry picked from commit ef714b6cb7579575c950ead45a8d6fda917354ae) > Why is it a cherry-pick? I will fix up this commit message http://gerrit.cloudera.org:8080/#/c/20095/4/shell/make_shell_tarball.sh File shell/make_shell_tarball.sh: http://gerrit.cloudera.org:8080/#/c/20095/4/shell/make_shell_tarball.sh@109 PS4, Line 109: # This builds each package to a wheel, then unpacks the wheel into the corresponding > Why can't we pip install the wheel? Good point, I will see how to do this with pip install. I used unzip just because it is easy, but there must be a way to do that. -- To view, visit http://gerrit.cloudera.org:8080/20095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49403979c559b7f8bbe038865c06db6024468d72 Gerrit-Change-Number: 20095 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 20 Jun 2023 18:26:42 +0000 Gerrit-HasComments: Yes
