Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20099 )
Change subject: PROTOTYPE #2 IMPALA-12220: Build impala-shell tarball using pip install ...................................................................... Patch Set 1: (2 comments) > This is very similar to https://gerrit.cloudera.org/c/18668/. Yes, I definitely grabbed code / inspiration from that review. I think this approach is something that makes more sense than what we are doing with eggs, so I'm going to pull in more of that review (deleting ext-py, etc). http://gerrit.cloudera.org:8080/#/c/20099/1/shell/impala-shell File shell/impala-shell: http://gerrit.cloudera.org:8080/#/c/20099/1/shell/impala-shell@a62 PS1, Line 62: : : : > I think that's correct. The way to test that this is no longer needed is to I ran docker with the shell/build directory mounted, then I installed python2 / cyrus-sasl / etc without installing setuptools. I unpacked the shell tarball and I was able to run impala-shell and get a prompt (but there was nothing for it to connect to). So, this seems to work. i.e. docker run -v ${IMPALA_HOME}/shell/build/:/mnt/shell -it --entrypoint bash ubuntu:20.04 http://gerrit.cloudera.org:8080/#/c/20099/1/shell/make_shell_tarball.sh File shell/make_shell_tarball.sh: http://gerrit.cloudera.org:8080/#/c/20099/1/shell/make_shell_tarball.sh@a169 PS1, Line 169: > This means we could remove pkg_resources.py from the source tree too. Yes, I'll remove that. -- To view, visit http://gerrit.cloudera.org:8080/20099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d1dd804981bc102862c743bdf26d689553f4668 Gerrit-Change-Number: 20099 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 20 Jun 2023 22:39:45 +0000 Gerrit-HasComments: Yes
