Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20066 )
Change subject: IMPALA-12210: CatalogD should ignore validWriteId List if the table is external while loading a table ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20066/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/20066/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2224 PS2, Line 2224: LOG.trace("returning already loaded table {}", tbl.getFullName()); It seems we forget to update the metrics of hits here. Could you fix it by the way? E.g. extract code in line 2235-2244 into a method and call it here as well. -- To view, visit http://gerrit.cloudera.org:8080/20066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28a34185c788a39aa902b0cd1ed0ba0c8c376ff1 Gerrit-Change-Number: 20066 Gerrit-PatchSet: 2 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 22 Jun 2023 22:32:55 +0000 Gerrit-HasComments: Yes
