Hello Michael Smith, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20118

to look at the new patch set (#4).

Change subject: IMPALA-12242: Fix failover case in 
bin/cmake_aux/create_py3_virtualenv.sh
......................................................................

IMPALA-12242: Fix failover case in bin/cmake_aux/create_py3_virtualenv.sh

bin/cmake_aux/create_py3_virtualenv.sh will try to use
"python3 -m venv", but if it fails, it wants to fall back
to using impala-virtualenv. Unfortunately, the "python3 -m venv"
command left behind a directory and impala-virtualenv can't
handle it.

This removes the venv directory created by "python3 -m venv"
before falling back to impala-virtualenv.

Testing:
 - Remove python3-venv from bin/bootstrap_build.sh and ran
   it on a fresh Ubuntu 20 machine. This scenario would
   fail without the fix.

Change-Id: Ic20d5b2fba3da3c5358e3ab5513885389bb9eeaa
---
M bin/cmake_aux/create_py3_virtualenv.sh
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/20118/4
--
To view, visit http://gerrit.cloudera.org:8080/20118
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic20d5b2fba3da3c5358e3ab5513885389bb9eeaa
Gerrit-Change-Number: 20118
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>

Reply via email to