Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19185 )
Change subject: IMPALA-11694: Convert gutil atomic ops to C++ atomics ...................................................................... Patch Set 7: Code-Review+1 I took a look at this patch, and overall it looks OK to me. I didn't verify it compiles and work for Kudu on Apple M1 chips since I don't have access to those, and people who have those machines are offline for the weekend. I think it will take some time to understand whether this patch work as-is for Kudu from code and performance perspective, but from quick glance I didn't see any issues. I guess we will get more details after we back-porting this to Kudu and running benchmarks. Otherwise, I don't want to delay this anymore since it's an important piece of functionality for people using Impala. -- To view, visit http://gerrit.cloudera.org:8080/19185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d1e3f4e71988a6c464071c1cd8bdebce622e4b8 Gerrit-Change-Number: 19185 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 30 Jun 2023 23:23:06 +0000 Gerrit-HasComments: No
