Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 )
Change subject: IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads ...................................................................... Patch Set 3: (1 comment) Thanks for the quick review! Fix losing create event ids in REFRESH. http://gerrit.cloudera.org:8080/#/c/20145/2/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20145/2/tests/custom_cluster/test_events_custom_configs.py@847 PS2, Line 847: "alter table %s.part partition(p=0) set tblproperties('k'='v')" % unique_database, > Should we try compaction also here? Good point. However, these are executed in Impala. We haven't supported triggering compactions yet. Neither do we support these ALTER statements on transactional tables. Note that this test is to verify that DDLs in Impala won't lose the tracked create event ids in partition-level. -- To view, visit http://gerrit.cloudera.org:8080/20145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I052faa093bda69fb16db0d424c1478bba103dad9 Gerrit-Change-Number: 20145 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 30 Jun 2023 23:24:48 +0000 Gerrit-HasComments: Yes
