Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19850 )
Change subject: IMPALA-11619: Improve Iceberg V2 reads with a custom Iceberg Position Delete operator ...................................................................... Patch Set 22: (5 comments) http://gerrit.cloudera.org:8080/#/c/19850/23/be/src/exec/iceberg-delete-node.cc File be/src/exec/iceberg-delete-node.cc: http://gerrit.cloudera.org:8080/#/c/19850/23/be/src/exec/iceberg-delete-node.cc@63 PS23, Line 63: // TODO: simplify this by ensuring that UseSeparateBuild() is accurate in Init(). > nit: could you create a Jira for this? Done http://gerrit.cloudera.org:8080/#/c/19850/23/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/19850/23/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@722 PS23, Line 722: > Our operator is not a null-aware anti join, as neither side can be NULL. We Done http://gerrit.cloudera.org:8080/#/c/19850/23/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@752 PS23, Line 752: + " row > file path Done http://gerrit.cloudera.org:8080/#/c/19850/23/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@778 PS23, Line 778: ition: cost=" + Long.toString(partitionCost)); : LOG.trace("lhs card=" + Long.toString(lhsTree.getCardinality()) > We only need to compute this if the user haven't specified it via the query Done http://gerrit.cloudera.org:8080/#/c/19850/22/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/19850/22/tests/query_test/test_iceberg.py@1121 PS22, Line 1121: # > flake8: E265 block comment should start with '# ' Done -- To view, visit http://gerrit.cloudera.org:8080/19850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I024a61573c83bda5584f243c879d9ff39dd2dcfa Gerrit-Change-Number: 19850 Gerrit-PatchSet: 22 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 04 Jul 2023 12:29:15 +0000 Gerrit-HasComments: Yes
