Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 )
Change subject: IMPALA-11068: Add tuning flag to reduce scanner thread launch. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18126/1/be/src/runtime/scanner-mem-limiter.cc File be/src/runtime/scanner-mem-limiter.cc: http://gerrit.cloudera.org:8080/#/c/18126/1/be/src/runtime/scanner-mem-limiter.cc@90 PS1, Line 90: addtl_consumption += static_cast<int64_t>(consumption * 0.5); > I agree that making this tunable via query option is better. It will result After some internal discussion, we come up with conclusion that query option is be the best way to tune this. I'll implement it in next patch set. -- To view, visit http://gerrit.cloudera.org:8080/18126 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03cadf1230eed00d69f2890c82476c6861e37466 Gerrit-Change-Number: 18126 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 10 Jul 2023 17:07:29 +0000 Gerrit-HasComments: Yes
