Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20174/2/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/20174/2/be/src/service/fe-support.cc@a215 PS2, Line 215: This was added in IMPALA-358. result_bytes is initialized in this function and returned by the function, so I agree we shouldn't release everything created in this frame. As far as I can tell result_bytes is the only JNI object allocated in this function. The local reference to result_bytes will disappear when the function returns, which is immediately after allocating and filling it. -- To view, visit http://gerrit.cloudera.org:8080/20174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694 Gerrit-Change-Number: 20174 Gerrit-PatchSet: 2 Gerrit-Owner: zhangqianqiong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 10 Jul 2023 17:24:10 +0000 Gerrit-HasComments: Yes
