Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20196 )

Change subject: IMPALA-12284: Use Maven's batch mode when building jamm
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20196/1/java/CMakeLists.txt
File java/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/20196/1/java/CMakeLists.txt@30
PS1, Line 30:   BUILD_COMMAND     mvn -B --toolchains toolchains.xml install 
-Dmaven.test.skip=true -DskipTests
nit: I'd prefer --batch-mode.



--
To view, visit http://gerrit.cloudera.org:8080/20196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1634240b191168b13cf3be7c9266e21a746844b1
Gerrit-Change-Number: 20196
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Fri, 14 Jul 2023 17:35:06 +0000
Gerrit-HasComments: Yes

Reply via email to