Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18939 )
Change subject: IMPALA-10262: RPM/DEB Packaging Support ...................................................................... Patch Set 10: > I ran the command './buildall.sh -noclean -notests -release > -package' and found the ctests were built even with '--notests' > option. I ran into that on my system as well. -notests doesn't change the actual dependency graph generated by CMake (i.e. all the targets including the tests still exist). It instead works by changing the make target that buildall.sh invokes, and that make target doesn't build the tests. We did that so that developers could afterward build a single test after doing a -notests build. e.g. "make promise-test" It looks like cpack is invoking "make" without a target and that builds everything including all the tests. I will file a JIRA to see if we can have a mode that doesn't build any tests. -- To view, visit http://gerrit.cloudera.org:8080/18939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64419fd400fe8d233dac016b6306157fe9461d82 Gerrit-Change-Number: 18939 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 14 Jul 2023 23:29:08 +0000 Gerrit-HasComments: No
