Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20201
to look at the new patch set (#8).
Change subject: IMPALA-12278: Adding query option max_error_message_length
......................................................................
IMPALA-12278: Adding query option max_error_message_length
RuntimeState::LogError() does both error aggregation to the
coordinator and logging the error to the log file depending on
the vlog_level. If too many error logs are sent to the coordinator,
it is likely that the coordinator's memory usage will exceed the
limit. This patch limits the length of error message based on
max_error_message_length query option(default is 1024).
Testing:
- Add a test in test_logging.py::TestLoggingCore
Change-Id: I22bd1fe8b15ab83fe5f6fd4d5455c5f68e247ba6
---
M be/src/runtime/runtime-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M be/src/util/error-util-internal.h
M be/src/util/error-util.cc
M be/src/util/error-util.h
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M tests/custom_cluster/test_logging.py
9 files changed, 68 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/20201/8
--
To view, visit http://gerrit.cloudera.org:8080/20201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22bd1fe8b15ab83fe5f6fd4d5455c5f68e247ba6
Gerrit-Change-Number: 20201
Gerrit-PatchSet: 8
Gerrit-Owner: ttttttz <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: ttttttz <[email protected]>
