Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20131 )
Change subject: IMPALA-12152: Add query option to wait for events sync up ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/20131/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/20131/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3816 PS4, Line 3816: Thread.sleep(500); How did you arrive at this value for sleep? http://gerrit.cloudera.org:8080/#/c/20131/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3826 PS4, Line 3826: res.setStatus(new TStatus(TErrorCode.GENERAL, Lists.newArrayList(err))); Most other places you've written to the log as well. Seems like we should do that here. http://gerrit.cloudera.org:8080/#/c/20131/4/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/20131/4/tests/common/impala_test_suite.py@1025 PS4, Line 1025: LOG.info(stmt) Commit message should probably have a comment about this. -- To view, visit http://gerrit.cloudera.org:8080/20131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36ac941bb2c2217b09fcfa2eb567b011b38efa2a Gerrit-Change-Number: 20131 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 19 Jul 2023 20:45:06 +0000 Gerrit-HasComments: Yes
