Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20192 )
Change subject: IMPALA-12267: DMLs/DDLs can hang as a result of catalogd restart ...................................................................... Patch Set 6: Code-Review+1 (2 comments) > I fixed the TODOs. The defaults are still at 5 minutes and 10 iterations, but > we could change them. Thanks for applying the changes! I'm ok with these defaults. The current patch LGTM. http://gerrit.cloudera.org:8080/#/c/20192/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/20192/5/be/src/service/impala-server.cc@2267 PS5, Line 2267: LOG(WARNING) << "Received " << num_statestore_updates << " non-empty" > I removed the ShouldContinueWaitingForNewCatalogServiceId() function and ad Yeah, that looks better. http://gerrit.cloudera.org:8080/#/c/20192/6/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/20192/6/be/src/service/impala-server.cc@2228 PS6, Line 2228: // The catalog service ID of 'catalog_update_result' does not match the current nit: The current method is quite long now. We can extract L2228-2286 into a method, e.g. WaitForNewCatalogServiceId() which accepts the current service id and returns the new service id. -- To view, visit http://gerrit.cloudera.org:8080/20192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib71bec8f67f80b0bdfe0a6cc46a16ef624163d8b Gerrit-Change-Number: 20192 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 24 Jul 2023 13:53:20 +0000 Gerrit-HasComments: Yes
