Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19506 )
Change subject: IMPALA-11924: Cap runtime filter NDV with build key NDV ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/19506/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19506/7//COMMIT_MSG@20 PS7, Line 20: - Verified manually that the example in the ticket is fixed. > Why don't we add a test case for this? There is actually test cases that indirectly assert the bloom filter size: test_bloom_filters and test_row_filters. Filter size do shrink after this patch, indicated by test failure in patch set 4 like this: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/19875/ Patch set 6 and 7 adjust the test case instead of changing the assertion. -- To view, visit http://gerrit.cloudera.org:8080/19506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaa46789663cb2e6d29f518757d89c85ff8e4d1a Gerrit-Change-Number: 19506 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 28 Jul 2023 19:43:01 +0000 Gerrit-HasComments: Yes
