Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20274

to look at the new patch set (#3).

Change subject: IMPALA-12319: Fix NullPointerException in 
UnnestExpr.isBoundByTupleIds()
......................................................................

IMPALA-12319: Fix NullPointerException in UnnestExpr.isBoundByTupleIds()

UnnestExpr can be used in a sort tuple which won't have a resolved path.
In such case, there is no parent tuple id so we should not check it in
UnnestExpr.isBoundByTupleIds(). This fixes the NullPointerException.

Tests
 - Added fe and e2e tests for sorting columns come from unnest().
 - Move test_zipping_unnest_from_view to a dedicated class that only has
   the parquet file_format dimension to make sure it also runs in "core"
   exploration strategy. Before this it only runs in "exhaustive"
   strategy.

Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
---
M fe/src/main/java/org/apache/impala/analysis/UnnestExpr.java
M testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test
M 
testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-from-view.test
M tests/query_test/test_nested_types.py
4 files changed, 257 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/20274/3
--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>

Reply via email to