Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20294 )

Change subject: IMPALA-12288: Add BUILD_WITH_NO_TESTS option to remove test 
targets
......................................................................


Patch Set 1: -Code-Review

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20294/1/be/src/common/CMakeLists.txt
File be/src/common/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/20294/1/be/src/common/CMakeLists.txt@70
PS1, Line 70: CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/config.h.in
This needs to be before the return().



--
To view, visit http://gerrit.cloudera.org:8080/20294
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I575ce76176c9f6a05fd2db0f420ebe6926d0272a
Gerrit-Change-Number: 20294
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Tue, 01 Aug 2023 23:14:31 +0000
Gerrit-HasComments: Yes

Reply via email to