Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20168 )
Change subject: IMPALA-12269: Codegen cache false negative because of function names hash ...................................................................... Patch Set 5: Code-Review+1 (2 comments) It looks good. Could Csaba have one more look at the patch after changing to use map for codegen functions? http://gerrit.cloudera.org:8080/#/c/20168/5/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20168/5/be/src/codegen/llvm-codegen.cc@1202 PS5, Line 1202: nit. unnecessary newline http://gerrit.cloudera.org:8080/#/c/20168/5/be/src/codegen/llvm-codegen.cc@1438 PS5, Line 1438: // Get pointers to all codegen'd functions. Because for SetFunctionPointers() "either both or none of 'cache' and 'cache_key' should be NULL", can we add a DCHECK here for cache and cache_key to make sure they meet our requirement? -- To view, visit http://gerrit.cloudera.org:8080/20168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf1d2b424c969fbba181ab90bf9c7bf22355f139 Gerrit-Change-Number: 20168 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 01 Aug 2023 23:18:00 +0000 Gerrit-HasComments: Yes