[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/19569 )
Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() ...................................................................... Patch Set 16: > Patch Set 16: > > (1 comment) Please ignore patch 15. I've removed 2 tests from the patch: select s_store_sk, regr_slope(s_number_employees, s_floor_space) over (partition by s_city order by s_store_sk rows between 1 preceding and 1 following) from tpcds.store; and select s_store_sk, regr_intercept(s_number_employees, s_floor_space) over (partition by s_city order by s_store_sk rows between 1 preceding and 1 following) from tpcds.store; as they were resulting in wrong results when compared to hive. The reason for the wrong results does not correspond to the code but is because of different implementaion for evaluating window functions in Hive and Impala. This was verified by runnig a query independent of regression functions. A separate jira can be filed to look further into it. -- To view, visit http://gerrit.cloudera.org:8080/19569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab6bd84ae3e0c02ec924c30183308123b951caa3 Gerrit-Change-Number: 19569 Gerrit-PatchSet: 16 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 04 Aug 2023 07:19:28 +0000 Gerrit-HasComments: No
