Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17842 )
Change subject: IMPALA-5741: Support reading tiny RDBMS tables ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/17842/9/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/17842/9/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@131 PS9, Line 131: dbAccessor = DatabaseAccessorFactory.getAccessor(tableConfig); > Is it possible to create dbAccessor in prepare() API and get totalNumberOfR Planner create ExternalDataSourceExecutor and JdbcDataSource instances on stack, then call prepare() API. Backend create separate instances of ExternalDataSourceExecutor and JdbcDataSource to call open(), getNext() and close() APIs. Settings of member variables in prepare() API are not passed to subsequent APIs. We could create dbAccessor in prepare(), but we have to create it again in open(). -- To view, visit http://gerrit.cloudera.org:8080/17842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8244e978c7717c6f1452f66f1630b6441392e7d2 Gerrit-Change-Number: 17842 Gerrit-PatchSet: 9 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 04 Aug 2023 20:10:30 +0000 Gerrit-HasComments: Yes
