Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20148 )
Change subject: IMPALA-12257: Fix NPE in createInsertEvents when partitions only exist in HMS ...................................................................... Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/20148/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20148/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6840 PS5, Line 6840: Exception I am not sure about catching all Exceptions, as if there is am actual problem then we should be able to detect it to fix it. http://gerrit.cloudera.org:8080/#/c/20148/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6973 PS5, Line 6973: // ACID inserts do not generate INSERT events as it is enough to listen to the : // COMMIT event fired by HMS. Impala ignores COMMIT events, so we don't : // have to worry about reloading as a result of this "self" event. : // Note that Hive inserts also lead to an ALTER event which is the actual event : // that causes Impala to reload the table. Not related to the change, but this comment is stale now. I wrote this in IMPALA-10692, but since IMPALA-10923 we also listen for CommitTxnEvent. I think that we detect ACID inserts with CommitTxnEvent, as since IMPALA-11534 we are ignoring most ALTER TABLE events, probably also the one mentioned here. So the correct comment would be that we do not need need self event handling here for ACID inserts, as we are listening for the commit's event. I am not sure though whether we detect self events for our own commits. http://gerrit.cloudera.org:8080/#/c/20148/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7008 PS5, Line 7008: * based on the iteration order. Can you mention that this is not called for Hive ACID tables? -- To view, visit http://gerrit.cloudera.org:8080/20148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d77844e26283ecb16b3b3aeb9f634bb3113eacd Gerrit-Change-Number: 20148 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 07 Aug 2023 12:28:33 +0000 Gerrit-HasComments: Yes
