Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20331 )
Change subject: IMPALA-12346: Explicitly disable ICU dependency for Boost locale build ...................................................................... IMPALA-12346: Explicitly disable ICU dependency for Boost locale build Boost locale has two implementations: one uses the ICU library to implement locale support and the other uses only standard C++ libraries. Impala currently uses the non-ICU implementation. However, if ICU is installed before Boost is built, then Boost will use it by default. This leads to link errors, because the Impala build doesn't link in ICU. This passes the boost.locale.icu=off flag to the Boost build to force it to build the non-ICU implementation even if ICU is installed. This is important to the ARM core job. Testing: - Ran an ARM core job with this custom native-toolchain - Ran a normal toolchain build Change-Id: I9d2dcfe82bd63beb43475b4556a5d44a4329534b Reviewed-on: http://gerrit.cloudera.org:8080/20331 Reviewed-by: Michael Smith <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- M source/boost/build.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Smith: Looks good to me, approved Joe McDonnell: Verified -- To view, visit http://gerrit.cloudera.org:8080/20331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9d2dcfe82bd63beb43475b4556a5d44a4329534b Gerrit-Change-Number: 20331 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
