Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20022 )
Change subject: IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20022/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20022/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1527 PS4, Line 1527: reloadFileMetadata, reloadTableSchema, false, partitionsToUpdate, : debugAction, partitionToEventId, reason); > I am still trying to understand what will happen here. For example when cal Fair point!! Let's update the lastRefreshEventId only when reloadFileMetadata and reloadTableSchema both are set to true. I don't think having two different flags for tableSchema and fileMetadata at this point is useless. Because after IMPALA-10976, we are gonna combine creatEventId, lastRefreshEventId, LastSyncEventId e.t.c all these flags into one single flag. http://gerrit.cloudera.org:8080/#/c/20022/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/20022/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3233 PS4, Line 3233: "test", null); : Long lastSyncEvenIdBefore = testTbl.getLastRefreshEventId(); : eventsProcessor_.processEvents(); > Wouldn't it be better to save the value of testTbl.getLastRefreshEventId() Ack -- To view, visit http://gerrit.cloudera.org:8080/20022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0dc5c7396d80616680d8a5805ce80db293b72e1 Gerrit-Change-Number: 20022 Gerrit-PatchSet: 6 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 09 Aug 2023 17:04:08 +0000 Gerrit-HasComments: Yes
