Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20175 )
Change subject: IMPALA-12274 Fix memory leak because of the local reference catalog was not released ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20175/1/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: http://gerrit.cloudera.org:8080/#/c/20175/1/be/src/catalog/catalog.cc@75 PS1, Line 75: // Used to release the local reference catalog created by `NewObject` I think not just 'catalog', the jbyteArray 'cfg_bytes' is also created in this scope: https://github.com/apache/impala/blob/63c435cac11a623693402a2197efdf3b928bd349/be/src/rpc/jni-thrift-util.h#L47 We can simply said: "Used to release local references promptly" http://gerrit.cloudera.org:8080/#/c/20175/1/be/src/catalog/catalog.cc@80 PS1, Line 80: catalog_class_ not related to this patch but could you also make this a local variable? -- To view, visit http://gerrit.cloudera.org:8080/20175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93ea3270dcba3ad4903aa053cc283d4f700e948 Gerrit-Change-Number: 20175 Gerrit-PatchSet: 3 Gerrit-Owner: zhangqianqiong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: zhangqianqiong <[email protected]> Gerrit-Comment-Date: Mon, 14 Aug 2023 07:52:55 +0000 Gerrit-HasComments: Yes
