Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20267 )
Change subject: [tools] Simplify local toolchain development ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20267/3/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/20267/3/bin/impala-config.sh@319 PS3, Line 319: IMPALA_TOOLCHAIN_PACKAGES_HOME=${IMPALA_TOOLCHAIN}/toolchain-local I was thinking it might be nice to combine this with some of the logic for aarch64 that automatically symlinks from NATIVE_TOOLCHAIN_HOME. So set an environment variable for the native toolchain repo and Impala takes care of the rest. -- To view, visit http://gerrit.cloudera.org:8080/20267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a9e51b7f54c738d8cc01b32428ac88a344de376 Gerrit-Change-Number: 20267 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 16 Aug 2023 15:46:31 +0000 Gerrit-HasComments: Yes
