Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20022 )
Change subject: IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/20022/7/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20022/7/tests/custom_cluster/test_events_custom_configs.py@348 PS7, Line 348: f.run_stmt_ > Can you also add a test with dynamic partitioning? Done http://gerrit.cloudera.org:8080/#/c/20022/7/tests/custom_cluster/test_events_custom_configs.py@357 PS7, Line 357: ocessorUtils.get_num_skip > Can't we use fixed numbers in the test, e.g. assert tbl_events_skipped_ Ack -- To view, visit http://gerrit.cloudera.org:8080/20022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0dc5c7396d80616680d8a5805ce80db293b72e1 Gerrit-Change-Number: 20022 Gerrit-PatchSet: 11 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sun, 20 Aug 2023 19:24:21 +0000 Gerrit-HasComments: Yes
