Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20396 )
Change subject: IMPALA-12393: Fix inconsistent hash for TimestampValue in DictEncoder ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20396/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20396/1//COMMIT_MSG@14 PS1, Line 14: This was discovered when fixing a Clang Tidy performance-for-range-copy > Was there a separate ticket for the warning? Or just looking into it lead t I was putting together an initial change for IMPALA-12390, but my GVO run failed on the DictTest.TestTimestamps test. This is what popped out. -- To view, visit http://gerrit.cloudera.org:8080/20396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad86e9b0f645311c3389cf2804dcc1a346ff10a9 Gerrit-Change-Number: 20396 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 22 Aug 2023 18:32:31 +0000 Gerrit-HasComments: Yes
