Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/19699 )
Change subject: IMPALA-10798: Initial support for reading JSON files ...................................................................... Patch Set 29: (6 comments) http://gerrit.cloudera.org:8080/#/c/19699/26//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19699/26//COMMIT_MSG@7 PS26, Line 7: Initial support for reading JSON fi > Let's change the title to something like "Initial support for reading JSON Done http://gerrit.cloudera.org:8080/#/c/19699/23/tests/data_errors/test_data_errors.py File tests/data_errors/test_data_errors.py: http://gerrit.cloudera.org:8080/#/c/19699/23/tests/data_errors/test_data_errors.py@128 PS23, Line 128: self.run_test_case('DataErrorsTest/hdfs-scan-node-errors', vector) > Can we add a similar test for json? Done http://gerrit.cloudera.org:8080/#/c/19699/23/tests/query_test/test_cancellation.py File tests/query_test/test_cancellation.py: http://gerrit.cloudera.org:8080/#/c/19699/23/tests/query_test/test_cancellation.py@113 PS23, Line 113: 'text' > Let's add json here Done http://gerrit.cloudera.org:8080/#/c/19699/23/tests/query_test/test_chars.py File tests/query_test/test_chars.py: http://gerrit.cloudera.org:8080/#/c/19699/23/tests/query_test/test_chars.py@37 PS23, Line 37: ptions > Let's test json here Done http://gerrit.cloudera.org:8080/#/c/19699/23/tests/query_test/test_chars.py@68 PS23, Line 68: > Let's test json here as well Done http://gerrit.cloudera.org:8080/#/c/19699/23/tests/query_test/test_date_queries.py File tests/query_test/test_date_queries.py: http://gerrit.cloudera.org:8080/#/c/19699/23/tests/query_test/test_date_queries.py@45 PS23, Line 45: > Let's add json here. Please also update the above comment. DATE type is als Done -- To view, visit http://gerrit.cloudera.org:8080/19699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31309cb8f2d04722a0508b3f9b8f1532ad49a569 Gerrit-Change-Number: 19699 Gerrit-PatchSet: 29 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Thu, 24 Aug 2023 11:10:37 +0000 Gerrit-HasComments: Yes
