Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 )
Change subject: IMPALA-10086: SqlCastException when comparing char with varchar ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/18001/2/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/18001/2/fe/src/main/java/org/apache/impala/analysis/Expr.java@1565 PS2, Line 1565: * compatibility level that defines the relation between 'targetType' and the > Changing this function doesn't seem to be sufficient. The following test ca This no longer crashes, but still doesn't give the results I'd expect. http://gerrit.cloudera.org:8080/#/c/18001/2/fe/src/main/java/org/apache/impala/analysis/Expr.java@1574 PS2, Line 1574: throws AnalysisException { > I can try to make this cleaner, and add some more test cases. Done -- To view, visit http://gerrit.cloudera.org:8080/18001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cd331ae1b6afb778a88080efd38900694539a89 Gerrit-Change-Number: 18001 Gerrit-PatchSet: 3 Gerrit-Owner: Bruno Pusztahazi <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 25 Aug 2023 22:28:34 +0000 Gerrit-HasComments: Yes
