Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20372 )

Change subject: IMPALA-12156: Support High Availability for Statestore
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/20372/3/be/src/statestore/statestore-subscriber.cc
File be/src/statestore/statestore-subscriber.cc:

http://gerrit.cloudera.org:8080/#/c/20372/3/be/src/statestore/statestore-subscriber.cc@865
PS3, Line 865:       // Try to acquire lock to avoid race with updating 
catalogd from registration thread.
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/20372/3/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:

http://gerrit.cloudera.org:8080/#/c/20372/3/bin/start-impala-cluster.py@793
PS3, Line 793: t
flake8: E501 line too long (94 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/20372/3/tests/custom_cluster/test_statestored_ha.py
File tests/custom_cluster/test_statestored_ha.py:

http://gerrit.cloudera.org:8080/#/c/20372/3/tests/custom_cluster/test_statestored_ha.py@24
PS3, Line 24: from tests.common.skip import SkipIf
flake8: F401 'tests.common.skip.SkipIf' imported but unused


http://gerrit.cloudera.org:8080/#/c/20372/3/tests/custom_cluster/test_statestored_ha.py@143
PS3, Line 143: p
flake8: F821 undefined name 'pytest'


http://gerrit.cloudera.org:8080/#/c/20372/3/tests/custom_cluster/test_statestored_ha.py@320
PS3, Line 320: "
flake8: E131 continuation line unaligned for hanging indent



--
To view, visit http://gerrit.cloudera.org:8080/20372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd2c814bbad5c04c1d50c2edaa5b910c82a6fd87
Gerrit-Change-Number: 20372
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Mon, 28 Aug 2023 16:47:30 +0000
Gerrit-HasComments: Yes

Reply via email to