Gergely Farkas has posted comments on this change. ( http://gerrit.cloudera.org:8080/20421 )
Change subject: IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/20421/2/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/20421/2/be/src/service/impala-hs2-server.cc@404 PS2, Line 404: username > The name is a bit ambiguous to me, as we do not change the actual user name Done http://gerrit.cloudera.org:8080/#/c/20421/2/be/src/service/impala-hs2-server.cc@406 PS2, Line 406: !connection_context->kerberos_user_principal.empty()) { > nit, indentation: -2 for most lines Thanks! http://gerrit.cloudera.org:8080/#/c/20421/2/be/src/service/impala-hs2-server.cc@410 PS2, Line 410: OG(1) << " > Maybe VLOG(1) is enough for this? If the tests use Impala in this way then Done http://gerrit.cloudera.org:8080/#/c/20421/2/fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/20421/2/fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java@190 PS2, Line 190: > we use /cliservice in all other tests, maybe it is also needed here? Good point! I've updated it.Thanks! -- To view, visit http://gerrit.cloudera.org:8080/20421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0141cd341cda84ed40cd72f8a038c8d5a215e5e1 Gerrit-Change-Number: 20421 Gerrit-PatchSet: 5 Gerrit-Owner: Gergely Farkas <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Farkas <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 30 Aug 2023 07:18:31 +0000 Gerrit-HasComments: Yes
