Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20429 )
Change subject: IMPALA-12409: Don't allow EXTERNAL Iceberg tables to point another Iceberg table in Hive catalog ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20429/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/20429/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@778 PS2, Line 778: if (isExternalWithNoPurge() && IcebergUtil.isHiveCatalog(getTblProperties())) { > So we are allowed to create such an external table if we provide 'external. Never mind, I tried it out, and with 'external.table.purge'=true the table is considered a managed table so it gives an exception during creation: AnalysisException: Table requires at least 1 column for managed iceberg table -- To view, visit http://gerrit.cloudera.org:8080/20429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb0d7f0e7ec40fba356bd58b43f68d070432de71 Gerrit-Change-Number: 20429 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 31 Aug 2023 08:55:45 +0000 Gerrit-HasComments: Yes
