Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@508 PS7, Line 508: # IMPALA-11768 -- Insert partition events should be ignored > Could you split this into another test since it's a separated issue? Ack http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@512 PS7, Line 512: "insert into {}.{} partition(year=2023) values (1,2)" > This is a new partition. I don't see an INSERT event is generated. Instead, I overlooked this point. Add a insert event in the latest patch http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@517 PS7, Line 517: assert EventProcessorUtils.get_event_processor_status() == "ACTIVE" > Shouldn't we need Impala side changes to catch the InvalidObjectException t Ack http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@519 PS7, Line 519: > nit: two blank lines here. Let's keep one. Ack -- To view, visit http://gerrit.cloudera.org:8080/20420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3 Gerrit-Change-Number: 20420 Gerrit-PatchSet: 7 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 31 Aug 2023 19:36:56 +0000 Gerrit-HasComments: Yes
