Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20345 )
Change subject: IMPALA-12361: Implementation of regr_count(), regr_avgx() and regr_avgy() ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20345/2/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20345/2/be/src/exprs/aggregate-functions-ir.cc@433 PS2, Line 433: DoubleVal AggregateFunctions::RegrAvgGetValue(FunctionContext* ctx, const StringVal& src) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20345/2/be/src/exprs/aggregate-functions-ir.cc@441 PS2, Line 441: DoubleVal AggregateFunctions::RegrAvgFinalize(FunctionContext* ctx, const StringVal& src) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20345/2/be/src/exprs/aggregate-functions.h File be/src/exprs/aggregate-functions.h: http://gerrit.cloudera.org:8080/#/c/20345/2/be/src/exprs/aggregate-functions.h@68 PS2, Line 68: static void RegrCountUpdate(FunctionContext*, const DoubleVal& src1, const DoubleVal& src2, BigIntVal* dst); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/20345/2/be/src/exprs/aggregate-functions.h@69 PS2, Line 69: static void RegrCountRemove(FunctionContext*, const DoubleVal& src1, const DoubleVal& src2, BigIntVal* dst); line too long (110 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia17c565758565b868d3a54b3ebc12da51c37e143 Gerrit-Change-Number: 20345 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 04 Sep 2023 10:15:01 +0000 Gerrit-HasComments: Yes
