Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20439 )
Change subject: IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20439/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/20439/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@139 PS3, Line 139: EMPTY_ROLES No need to create.a field just for this usage. We can use Collections.emptySet() directly. It actually reuses an internal field for each call. https://docs.oracle.com/javase/8/docs/api/java/util/Collections.html#emptySet-- -- To view, visit http://gerrit.cloudera.org:8080/20439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id80fc2c9152a09194718da1b4266c5f804f0971f Gerrit-Change-Number: 20439 Gerrit-PatchSet: 3 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 04 Sep 2023 13:20:16 +0000 Gerrit-HasComments: Yes
