Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20453
Change subject: IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala ...................................................................... IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala Trino creates Iceberg tables without 'engine.hive.enabled'='true'. It also doesn't provide a way for users to set this property. Therefore Trino always creates Iceberg tables with non-HiveIceberg storage descriptors. Impala uses the Input/Output/SerDe properties to recognize table types. This change relaxes this a bit for Iceberg tables, i.e. a table is also considered to be an Iceberg table if the table property 'table_type'='ICEBERG' is set. During table loading Impala uses an internal HDFS table to load table metadata. It currently throws an exception when no proper storage descriptor is being set. To workaround this, IcebergTable changes the in-memory HMS table's storage descriptor properties to the HiveIceberg* properties. Normally, this shouldn't persist to the HMS database on read operations. Though it wouldn't harm AFAICT, we just want to be on the safe side. Modifications to the table from Impala goes through its Iceberg libary (with 'engine.hive.enabled'='true'), which means we set the HiveIceberg storage descriptors. Trino is still compatible with such tables. Testing * Manually tested with Trino * IMPALA-12422 will add interop tests once we have Trino in the minicluster environment Change-Id: I18ea3858314d70a6131982a4e4d3ca90a95a311a --- M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java 3 files changed, 28 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/20453/1 -- To view, visit http://gerrit.cloudera.org:8080/20453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I18ea3858314d70a6131982a4e4d3ca90a95a311a Gerrit-Change-Number: 20453 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
