Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20454 )
Change subject: IMPALA-12416: Fix test failures caused by IMPALA-11535 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20454/1/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20454/1/tests/custom_cluster/test_events_custom_configs.py@365 PS1, Line 365: self.__get_transactional_tblproperties(True) if is_transactional else '' nit: why not use self.__get_transactional_tblproperties(is_transactional) directly? BTW, don't need the last semicolon ";" for a single statement -- To view, visit http://gerrit.cloudera.org:8080/20454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4930933dca849496bfbe475c8efc960d15fa57a8 Gerrit-Change-Number: 20454 Gerrit-PatchSet: 1 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 05 Sep 2023 23:29:11 +0000 Gerrit-HasComments: Yes
